Progress for Next.js #4468

paperdave · 2023-09-03T22:32:47Z

What does this PR do?

How did you verify your code works?

I've been testing with Next.js to get it farther.

codehz · 2023-09-04T02:37:34Z

#4236
will it expose same internal symbol (Symbol(kChannelHandle)) as node does?

paperdave · 2023-09-04T04:00:16Z

#4236
will it expose same internal symbol (Symbol(kChannelHandle)) as node does?

According to the node docs on IPC:

Accessing the IPC channel fd in any way other than process.send() or using the IPC channel with a child process that is not a Node.js instance is not supported.

The internal implementation I'm working with so far does not look anything like node's at all, so even if this symbol existed with some value, it simply wouldn't work. All of the IPC code is done in native.

This library should use "pipe" with a fourth file descriptor (scroll down in the docs link) instead of hijacking the Node IPC system for messages, it would be much cleaner on their end... however Bun/this per doesn't implement extra fds yet. The only way it would work right now is using stdout+stdin pipes.

github-actions · 2023-09-05T03:10:13Z

❌ @paperdave 11 files with test failures on bun-darwin-x64-baseline:

test/js/bun/sqlite/sqlite.test.js
test/js/bun/util/filesink.test.ts
test/js/node/child_process/child-process-stdio.test.js
test/js/node/child_process/child_process.test.ts
test/js/node/fs/fs.test.ts
test/js/node/http/node-http.test.ts
test/js/node/stream/bufferlist.test.ts
test/js/third_party/esbuild/esbuild-child_process.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/fetch/fetch.tls.test.ts
test/js/web/timers/setTimeout.test.js

View test output

^{#d8311f4cae3b6703e1d8e6338a26db7e52ee22f5}

src/js/node/v8.ts

src/js/node/fs.promises.ts

birkskyum · 2023-09-05T12:34:36Z

Closes #3620

github-actions · 2023-09-06T03:31:37Z

❌ @paperdave 17 files with test failures on bun-darwin-aarch64:

test/bundler/bundler_browser.test.ts
test/bundler/bundler_minify.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/importstar.test.ts
test/bundler/esbuild/splitting.test.ts
test/bundler/esbuild/ts.test.ts
test/cli/install/bunx.test.ts
test/js/bun/resolve/resolve.test.ts
test/js/bun/test/test-test.test.ts
test/js/node/assert/assert.test.cjs
test/js/node/assert/assert.test.ts
test/js/node/async_hooks/async_hooks.node.test.ts
test/js/node/path/path.test.js
test/js/node/process/process-args.test.js
test/js/node/util/test-util-types.test.js
test/js/node/util/util-promisify.test.js
test/js/node/watch/fs.watch.test.ts

View test output

^{#8a4284d4e501f843fea7a8b65cabce99928862d5}

github-actions · 2023-09-07T08:33:49Z

❌ @paperdave 7 files with test failures on linux-x64-baseline:

test/js/node/child_process/child-process-stdio.test.js
test/js/node/child_process/child_process.test.ts
test/js/node/fs/fs.test.ts
test/js/node/http/node-http.test.ts
test/js/node/stream/bufferlist.test.ts
test/js/third_party/esbuild/esbuild-child_process.test.ts
test/js/web/fetch/fetch-gzip.test.ts

View test output

^{#d8311f4cae3b6703e1d8e6338a26db7e52ee22f5}

github-actions · 2023-09-07T08:34:02Z

❌ @paperdave 6 files with test failures on linux-x64:

test/js/node/child_process/child-process-stdio.test.js
test/js/node/child_process/child_process.test.ts
test/js/node/fs/fs.test.ts
test/js/node/http/node-http.test.ts
test/js/node/stream/bufferlist.test.ts
test/js/third_party/esbuild/esbuild-child_process.test.ts

View test output

^{#d8311f4cae3b6703e1d8e6338a26db7e52ee22f5}

Hanaasagi · 2023-09-07T09:30:01Z

test/js/node/fs/fs.test.ts

@@ -2025,7 +2025,7 @@ it("BigIntStats", () => {
 it("test syscall errno, issue#4198", () => {
  const path = `${tmpdir()}/non-existent-${Date.now()}.txt`;
  expect(() => openSync(path, "r")).toThrow("No such file or directory");
-  expect(() => readSync(2147483640, Buffer.alloc(0))).toThrow("Bad file number");
+  expect(() => readSync(2147483640, Buffer.alloc(0))).toThrow("EBADF");


Suggested change

expect(() => readSync(2147483640, Buffer.alloc(0))).toThrow("EBADF");

if (os.platform() == "darwin") {

expect(() => readSync(2147483640, Buffer.alloc(0))).toThrow("Bad file descriptor");

} else {

expect(() => readSync(2147483640, Buffer.alloc(0))).toThrow("Bad file number");

}

os is not imported.

birkskyum · 2023-09-07T13:07:10Z

Tried to test this canary release, but it seems like something broke regarding macos arm64. https://github.com/oven-sh/bun/actions/runs/6109378228/job/16580283046

Grandnainconnu · 2023-10-13T16:26:33Z

process.send still not working with Bun 1.0.6 on macos arm64

paperdave · 2023-10-13T23:35:23Z

process.send is only defined when IPC is enabled. make sure you are using child_processs.fork to enable it, and note it only works for bun <-> bun communication right now.

paperdave force-pushed the dave/ipc branch from ea65d7a to a9b6848 Compare September 5, 2023 01:58

paperdave changed the title ~~feat(runtime): implement child_process.fork / ipc channels~~ NEXT.JS Sep 5, 2023

paperdave commented Sep 5, 2023

View reviewed changes

src/js/node/v8.ts Show resolved Hide resolved

paperdave commented Sep 5, 2023

View reviewed changes

src/js/node/fs.promises.ts Outdated Show resolved Hide resolved

paperdave changed the title ~~NEXT.JS~~ Progress for Next.js Sep 6, 2023

paperdave force-pushed the dave/ipc branch from 66bcdc9 to 09e7293 Compare September 6, 2023 02:34

paperdave marked this pull request as ready for review September 6, 2023 02:41

paperdave mentioned this pull request Sep 6, 2023

Make next dev work in Bun (pages dir) vercel/next.js#55045

Closed

paperdave force-pushed the dave/ipc branch from f5dc120 to 9e36513 Compare September 6, 2023 11:14

Eckhardt-D mentioned this pull request Sep 7, 2023

bun --bun run dev exits silently from 3.7.0 nuxt/cli#150

Closed

Hanaasagi reviewed Sep 7, 2023

View reviewed changes

paperdave added 12 commits September 7, 2023 03:50

L

78ce643

ipc

6b8adba

asdfghjkl

779e7cd

dfghjk

bc6a9a6

it works!

33ca9d5

types

7d0808c

patches for next.js

8b97d53

sdfghj

50ba9cc

wsdfgn,./

d674c5b

this

6caed31

yolo

a58eadd

okay loser

35b8e34

paperdave and others added 18 commits September 7, 2023 03:51

remove native events from streams

e063a47

stuff

58ca35e

remove lazy(primordials) test

c307b80

debugging

f1b77bb

okay

abebe0c

less fake extensions object

c827349

fix Buffer.toString() args logic

7357007

fix deserialize

58d5f9b

make tests work

4a88177

add test for Buffer.toString args

4531be8

Update server.zig

72622a5

remove test

1854119

update test

922eb5e

Update spawn-streaming-stdin.test.ts

cc20e9e

fix linux build

9189dc1

Update fs.test.ts

2164eb5

cli message improvements

9982268

dfshaj

1a82354

paperdave force-pushed the dave/ipc branch from 91ec7e9 to 1a82354 Compare September 7, 2023 10:51

paperdave added 2 commits September 7, 2023 04:25

Fix fs.watch bug maybe?

a6974c9

remove

0ff162b

paperdave merged commit 57a0674 into main Sep 7, 2023
11 of 13 checks passed

paperdave deleted the dave/ipc branch September 7, 2023 11:58

birkskyum mentioned this pull request Sep 7, 2023

Bun Create seems broken #4507

Closed

paperdave mentioned this pull request Sep 7, 2023

process.send is not a function using discord.js v14.12.1 #4159

Closed

birkskyum mentioned this pull request Sep 8, 2023

Support Nx #3786

Open

flyck mentioned this pull request Sep 9, 2023

Bun v1.0 Blogpost hendriknielaender/double-trouble#195

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Progress for Next.js #4468

Progress for Next.js #4468

paperdave commented Sep 3, 2023 •

edited

Loading

codehz commented Sep 4, 2023

paperdave commented Sep 4, 2023

github-actions bot commented Sep 5, 2023 •

edited

Loading

birkskyum commented Sep 5, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023 •

edited

Loading

Hanaasagi Sep 7, 2023 •

edited

Loading

birkskyum commented Sep 7, 2023

Grandnainconnu commented Oct 13, 2023

paperdave commented Oct 13, 2023

-  expect(() => readSync(2147483640, Buffer.alloc(0))).toThrow("EBADF");
+  if (os.platform() == "darwin") {
+    expect(() => readSync(2147483640, Buffer.alloc(0))).toThrow("Bad file descriptor");
+  } else {
+    expect(() => readSync(2147483640, Buffer.alloc(0))).toThrow("Bad file number");
+  }

Progress for Next.js #4468

Progress for Next.js #4468

Conversation

paperdave commented Sep 3, 2023 • edited Loading

What does this PR do?

How did you verify your code works?

codehz commented Sep 4, 2023

paperdave commented Sep 4, 2023

github-actions bot commented Sep 5, 2023 • edited Loading

birkskyum commented Sep 5, 2023

github-actions bot commented Sep 6, 2023

github-actions bot commented Sep 7, 2023 • edited Loading

github-actions bot commented Sep 7, 2023 • edited Loading

Hanaasagi Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

birkskyum commented Sep 7, 2023

Grandnainconnu commented Oct 13, 2023

paperdave commented Oct 13, 2023

paperdave commented Sep 3, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023 •

edited

Loading

Hanaasagi Sep 7, 2023 •

edited

Loading