Encode slashes in package names in the registry manifest request #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Max Brosnahan <1177034+gingermusketeer@users.noreply.github.com>
Jarred-Sumner
force-pushed
the
fix-scoped-install-from-aws-codeartifact
branch
from
8f2d2b6 to
108c5f8
Compare
beeb
reviewed
Sep 19, 2023
src/install/install.zig
Outdated
| // Not all registries support scoped package names when fetching the manifest. | ||
| // registry.npmjs.org supports both "@storybook%2Faddons" and "@storybook/addons" | ||
| // Other registries like AWS codeartifact only support the former. | ||
| // "npm" CLI requests the the manifest with the encoded name. |
|
Thanks for the quick fix! This will enable evaluation of Bun at my workplace, I'm super excited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5076
Supersedes #5484
How did you verify your code works?
Updated a test. We also need to add integration tests for Artifactory, Azure Artifacts, and more of those, but this PR doesn't do that.