Copy overrides from package.json during migration #7285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborchardt
force-pushed
the
hborchardt/pm_migrate_overrides
branch
from
a1817f4 to
ead4186
Compare
Jarred-Sumner
requested changes
Nov 25, 2023
hborchardt
force-pushed
the
hborchardt/pm_migrate_overrides
branch
from
ead4186 to
4faf9cd
Compare
|
@Jarred-Sumner I believe that no changes are necessary, please reconsider. Thanks! |
hborchardt
force-pushed
the
hborchardt/pm_migrate_overrides
branch
2 times, most recently
from
d58333c to
6a48da1
Compare
In case of overrides in the package.json, a different name property is used, which was not counted for.
hborchardt
force-pushed
the
hborchardt/pm_migrate_overrides
branch
from
6a48da1 to
2503950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7233
During migration of a
package-lock.jsontobun.lockb, this also parses thepackage.jsonfile to get the necessaryoverridessection and include it in the bun Lockfile. While writing the test, I also found a missing counting of the package name string length.How did you verify your code works?
I wrote automated tests
JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'edbun-debug test test-file-name.test)This is my first endeavour into zig, so I hope I got it right :) if not, feel free to criticise.