Fix error when parsing keys with hyphen in some JSON files

[DontBreakAlex]

What does this PR do?

Fixes #7261 introduced by #4783.
The solution is to quote export aliases when required so that

var key_with_hyphen = !0

export {
    key_with_hyphen as key-with-hyphen
};

export default { "key-with-hyphen": key_with_hyphen };

becomes

var key_with_hyphen = !0

export {
    key_with_hyphen as "key-with-hyphen"
};

export default { "key-with-hyphen": key_with_hyphen };

Relevant: tc39/ecma262#2154 and https://bugs.webkit.org/show_bug.cgi?id=217576

How did you verify your code works?

I wrote automated tests

• I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  I did not add allocations
• I included a test for the new code, or an existing test covers it
• I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test 07261.test.ts)

[DontBreakAlex]

Is there already a function that checks if a string is a valid variable name or do I need to write one ?

[Jarred-Sumner]

yeah, MutableString.ensureValidIdentifier. It will check if it's a valid identifier, and create a new one with the non-valid characters replaced by _ if it is not valid

[Jarred-Sumner]

Suggested change

	var maybe_quoted = name;
	var maybe_quoted = MutableString.ensureValidIdentifier(name, allocator) catch return null;

[DontBreakAlex]

We already use this function to create the name of temporary variable, and it replaces the hyphens with underscores. With your suggestion the code becomes this:

var key_with_hyphen = !0;

export {
  key_with_hyphen
};
export default { "key-with-hyphen": key_with_hyphen };

[DontBreakAlex]

So I figured It was not the bundler's job to handle quoting stuff. I instead modified to printer to quote aliases if they are not a valid identifier. This removes the need for allocation.

I think this PR is ready to be merged.

[paperclover]

thank you