Brotli decompression using JS implementation from Google (#267) #7749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It implements brotli decompression (#267) in JS using:
https://github.com/google/brotli/blob/master/js/decode.js
The file size is pretty big, I'm not sure of the impact on performance. If the impact is too high for those not using brotli, we could remove the dictionary, it is supposed to work anyway (https://en.wikipedia.org/wiki/Brotli#cite_note-14).
Pushing decoded
chunks
in thetransform
method does not work but I didnt investigate why because this version should be equivalent speed wise. The test case is pretty big so I did not include it.Thanks to @paperdave for his help on Discord.
How did you verify your code works?
bun-debug test test/js/node/zlib/zlib.test.js
)