NAPI fixes #7765
Merged
NAPI fixes #7765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bun.js/bindings/napi.cpp
Outdated
| MarkedArgumentBufferWithSize<12> args; | ||
| size_t argc = callFrame->argumentCount() + 1; | ||
| args.fill(vm, argc, [&](auto* slot) { | ||
| memcpy(slot, callFrame->addressOfArgumentsStart() - 1, sizeof(JSC::JSValue) * argc); |
There was a problem hiding this comment.
we do the -1 offset to copy this into slot?
There was a problem hiding this comment.
yeah i should write a comment here for this
its the this value's slot
|
❌ @Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:
|
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64:
|
|
❌ @Jarred-Sumner 4 files with test failures on linux-x64-baseline:
|
cirospaciari
approved these changes
Dec 21, 2023
|
❌ @Jarred-Sumner 6 files with test failures on bun-darwin-x64:
|
|
❌ @Jarred-Sumner 5 files with test failures on bun-darwin-x64-baseline:
|
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 1, 2024
* napi fixes * Make bcrypt work * Always return this * Fixes oven-sh#7685 * [autofix.ci] apply automated fixes * Update napi.cpp * Make it clearer what this is doing --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Also adds some of the missing aliases in expect, like
expect(...).toThrowErrorHow did you verify your code works?
Ran tests in argon2 and bcrypt