shell: add 'exit' builtin command #9705
Conversation
|
❌ @nektro 3 files with test failures on linux-x64-baseline: |
|
❌ @nektro 3 files with test failures on linux-x64: |
❌🪟 @nektro, there are 12 test regressions on Windows x86_64
|
|
❌ @nektro 4 files with test failures on bun-darwin-aarch64:
|
|
❌ @nektro 6 files with test failures on bun-darwin-x64:
|
| inline else => |tag| { | ||
| cmd.exec.bltn.impl = @unionInit(RealImpl, @tagName(tag), .{ | ||
| .bltn = &cmd.exec.bltn, | ||
| }); |
There was a problem hiding this comment.
Honestly not sure how I feel about this, it's definitely more concise than what we had previously but also makes it harder to understand what exactly is going on IMO.
There was a problem hiding this comment.
could you elaborate on this a bit?
There was a problem hiding this comment.
personally, i like it
it also encourages all the commands have the same interface
| } | ||
|
|
||
| pub fn deinit(this: *Exit) void { | ||
| _ = this; |
There was a problem hiding this comment.
is the memory owned by the parent struct?
There was a problem hiding this comment.
appears so checking all the other builtins
breaking out #9578 into multiple PRs in order to better pin down where my CI is going awry
edit: progress on #9716