Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL.canParse.length #9710

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix URL.canParse.length #9710

merged 3 commits into from
Mar 29, 2024

Conversation

PondWader
Copy link
Contributor

What does this PR do?

Fixes #9250

URL.canParse.length should be 1:
image

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test-file-name.test)

@PondWader PondWader changed the title Fix url can parse length Fix URL.canParse.length Mar 29, 2024
@jdalton
Copy link
Contributor

jdalton commented Mar 29, 2024

Thank you @PondWader!

@Jarred-Sumner Jarred-Sumner merged commit 9ecb691 into oven-sh:main Mar 29, 2024
24 of 30 checks passed
zloirock added a commit to zloirock/core-js that referenced this pull request Apr 1, 2024
@zloirock
URL.canParse fixed and marked as supported from Bun 1.1.0
589342c 
oven-sh/bun#9710
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
@dariosalvi78 dariosalvi78 mentioned this pull request May 19, 2024
Merged
@cb-sl cb-sl mentioned this pull request May 20, 2024
Open
@julitabarelkowska julitabarelkowska mentioned this pull request May 20, 2024
Open
@vinit-aikido vinit-aikido mentioned this pull request May 20, 2024
Open
@Shimizu-Kanaden-sys Shimizu-Kanaden-sys mentioned this pull request May 20, 2024
Open
@olokotoh olokotoh mentioned this pull request May 21, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
@AndrzejSmrokowski AndrzejSmrokowski mentioned this pull request May 22, 2024
Open
@marekful marekful mentioned this pull request May 22, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request May 23, 2024
Open
@patrick-zvenyika patrick-zvenyika mentioned this pull request May 23, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@JosanaDH JosanaDH mentioned this pull request May 24, 2024
Open
@samul-1 samul-1 mentioned this pull request May 24, 2024
Open
@Kypaku Kypaku mentioned this pull request May 24, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@FlorentinTh FlorentinTh mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@larkinwang20 larkinwang20 mentioned this pull request May 25, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 28, 2024
Open
@fiftin fiftin mentioned this pull request Sep 28, 2024
Closed
@AeonArriving AeonArriving mentioned this pull request Sep 30, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 1, 2024
Open
@marekful marekful mentioned this pull request Oct 1, 2024
Closed
@nejidevelops nejidevelops mentioned this pull request Oct 2, 2024
Open
@larkinwang20 larkinwang20 mentioned this pull request Oct 3, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 3, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 3, 2024
Open
@larkinwang20 larkinwang20 mentioned this pull request Oct 4, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 4, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Oct 5, 2024
Closed
This was referenced Oct 6, 2024
Open
Open
@algorox algorox mentioned this pull request Oct 8, 2024
Open
@arpitsourcefuse arpitsourcefuse mentioned this pull request Oct 24, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 25, 2024
Merged
@larkinwang20 larkinwang20 mentioned this pull request Oct 27, 2024
Open
@zrrv zrrv mentioned this pull request Oct 27, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 28, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 28, 2024
Open
@nfgallimore nfgallimore mentioned this pull request Oct 29, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 31, 2024
Open
@samul-1 samul-1 mentioned this pull request Oct 31, 2024
Open
@marcusmcclure marcusmcclure mentioned this pull request Nov 3, 2024
Open
@larkinwang20 larkinwang20 mentioned this pull request Nov 3, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Nov 4, 2024
Open
This was referenced Nov 5, 2024
Open
Open
@snykshane snykshane mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdalton jdalton jdalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL.canParse.length should be 1
3 participants
@PondWader @jdalton @Jarred-Sumner