Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add scoop installation method #9818

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Apr 2, 2024

What does this PR do?

Continuation of #7882

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@paperclover
Copy link
Member

As i posted in the #9806 PR

Before this is added, i want to solve this.
# Or if your CPU does not support the AVX2 instruction set. You can check by running this command:

This should not be manual. I will look into how this can be solved for winget later. If it is not solvable, I don't think we should recommend winget's usage for installing bun.

I'll take a look at how scoop works later and see what can be done.

@sitiom
Copy link
Contributor Author

sitiom commented Apr 3, 2024

As mentioned in the discord server a while ago, the check has been already been added to Scoop. But I thought might as well let the users know how to check it themselves 🤔
image-1.png

@paperclover
Copy link
Member

Is it possible to make so the pre_install script just downloads the correct one?

@Jarred-Sumner
Copy link
Collaborator

@sitiom thank you for this, but we can't in good faith add this to our docs as a recommended installation method until the baseline build detection is automatic

Any ideas how we can make scoop install bun choose the baseline build or regular build automatically, without asking users to make a decision and handle a confusing error?

@sitiom
Copy link
Contributor Author

sitiom commented Apr 4, 2024

I think the suggestion Please install 'bun-baseline' instead is clear. Although if you insist, it's possible for Scoop to download both and then do the check (although that means more download bandwidth), would that be fine?

CC @chawyehsu

@Jarred-Sumner
Copy link
Collaborator

I think the suggestion Please install 'bun-baseline' instead is clear.

It's clear to us, but we can't expect that from people trying Bun for the first time

it's possible for Scoop to download both and then do the check (although that means more download bandwidth), would that be fine?

I think that is a better tradeoff, one option would be to have 3 packages: bun, bun-windows-x64, bun-windows-x64-baseline and then the other 2 are dependencies of bun and then a small script would run to detect if they support AVX2 and if so, use the x64 build and otherwise fallback to use the x64-baseline build

@chawyehsu
Copy link
Contributor

I think the suggestion Please install 'bun-baseline' instead is clear. Although if you insist, it's possible for Scoop to download both and then do the check (although that means more download bandwidth), would that be fine?

CC @chawyehsu

I agree with you. And I personally don't like the idea of downloading additional zip on-the-fly via the pre_install script (which will take much unwanted work like validating checksums in an unusual way).

If you think the way Scoop currently provides is not good enough, I'd suggest you bundling bun and bun-baseline into one single zip so we can just download that single zip (or if it's not appropriate then we can download both of the two zips simultaneously) and expose the proper exec for our users based on detected microarch. This takes 2x bandwidth but is succincter and some other packages also do this way (in the way of bundling 32bit and 64bit).

@sitiom
Copy link
Contributor Author

sitiom commented Apr 4, 2024

@paperclover
Copy link
Member

legendary. will merge this after it lands in scoop.

@sitiom
Copy link
Contributor Author

sitiom commented Apr 4, 2024

@paperdave Now merged 🙂

@paperclover
Copy link
Member

incredible work

@Jarred-Sumner Jarred-Sumner merged commit 0b2bb1f into oven-sh:main Apr 5, 2024
1 check passed
@Jarred-Sumner
Copy link
Collaborator

Thank you

@sitiom sitiom deleted the patch-1 branch April 6, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants