-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deprecating input fields and arguments (InputObjectType) #1071
Allow deprecating input fields and arguments (InputObjectType) #1071
Conversation
f8f3118
to
3afaeaa
Compare
Hi @TaProhm, sorry for the late reply.
true as the second argument of getDescriptionConfiguration .
Can you also add tests? (just to ensure that it works when we add the directive in yaml or with annotations/attributes) |
@Vincz Thank you for pointing out in the right direction. As a result I stuck with" Overblog\GraphQLBundle\Tests\Functional\Type\DefinitionTest" for InputObjectType. It turned out there is an issue with webonyx/graphql-php regarding input values deprecation webonyx/graphql-php#110 |
Hi @TaProhm, it seems the issue in webonyx has been fixed: webonyx/graphql-php#110 |
Hi @Vincz It's only now that I've been able to give a detailed answer. I contributed to webonyx/graphql-php/issues/110 during my vacation, and then I was going to finish this PR. But now there is not enough time. However, this functionality is rather necessary, so I plan to finish it as soon as I can. |
b40f183
to
10d2ce4
Compare
@Vincz, I have updated this PR with actual commit containing new code and tests. It is ready to be reviewed. |
Awesome @TaProhm! Thank you very much for this :) |
The @deprecated directive is supported by this bundle for different GraphQL entities: Types, Objects, Interfaces, Enums.
But not for Inputs for some reason.