Feat: Upgrade to Quince #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll have to migrate to plugin API v1 and to the newest releases of superset/clickhouse/vector.
This is to address overhangio/tutor-mfe#122 As a consequence of this change, images will be tagged with a "-nightly" suffix. Next, we'll probably have to build them periodically in CI.
The package version number may not include the "-nightly" suffix. Otherwise, installation fails with: setuptools.extern.packaging.version.InvalidVersion: Invalid version: '15.0.7-nightly'
regisb
reviewed
Nov 23, 2023
| __version__ = "17.0.0" |
There was a problem hiding this comment.
Please rebase on top of nightly. From then on there should be just the __version__ variable here.
regisb
reviewed
Nov 23, 2023
There was a problem hiding this comment.
I got only minor comments. Can we deploy this on the demo server? https://github.com/overhangio/openedx-release-demo
| @@ -18,6 +18,10 @@ | |||
| # https://superset.apache.org/docs/installation/configuring-superset/#configuration-behind-a-load-balancer | |||
| ENABLE_PROXY_FIX = True | |||
|
|
|||
| {% if not ENABLE_HTTPS %} | |||
There was a problem hiding this comment.
What's talisman? Can you please add a comment to explain what it is, maybe with a link?
| "sl": {"flag": "si", "name": "Slovenian"}, | ||
| "nl": {"flag": "nl", "name": "Dutch"}, |
There was a problem hiding this comment.
Nice to get new languages! Please sort languages by key. Also, update the blob/dc57508... link above to point to version 3.0.1.
regisb
force-pushed
the
quince
branch
3 times, most recently
from
fb85393
to
476a856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Quince