feat: introduce course discovery repository settings #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
reviewed
Oct 27, 2023
Faraz32123
force-pushed
the
feat/introduce_course_discovery_repository_settings
branch
from
45361da to
d5dc2b0
Compare
regisb
reviewed
Nov 8, 2023
Faraz32123
force-pushed
the
feat/introduce_course_discovery_repository_settings
branch
from
d5dc2b0 to
559111c
Compare
Faraz32123
force-pushed
the
feat/introduce_course_discovery_repository_settings
branch
from
559111c to
8203a44
Compare
Faraz32123
force-pushed
the
feat/introduce_course_discovery_repository_settings
branch
from
8203a44 to
b38adab
Compare
regisb
reviewed
Nov 14, 2023
| @@ -32,6 +32,8 @@ | |||
| "OAUTH2_KEY_SSO_DEV": "discovery-sso-dev", | |||
| "CACHE_REDIS_DB": "{{ OPENEDX_CACHE_REDIS_DB }}", | |||
| "EXTRA_PIP_REQUIREMENTS": [], | |||
| "REPOSITORY": "https://github.com/openedx/course-discovery.git", | |||
| "REPOSITORY_VERSION": "{{ OPENEDX_COMMON_VERSION }}", | |||
There was a problem hiding this comment.
As discussed, it would be great if we would document these settings in the README. Since the README has no such docs for now, you can choose to do that in a separate PR.
regisb
approved these changes
Nov 14, 2023
Faraz32123
deleted the
feat/introduce_course_discovery_repository_settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.