Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.0.0 Upgrade to sumac #101

Merged
merged 8 commits into from
Dec 16, 2024
Merged

v19.0.0 Upgrade to sumac #101

merged 8 commits into from
Dec 16, 2024

Conversation

hinakhadim
Copy link
Collaborator

@hinakhadim hinakhadim commented Oct 18, 2024

v19.0.0 sumac release

Todos before merge

  • Ensure changelog exists for v19
  • Ensure CI/Tests are working as expected
  • Ensure sumac branch is up-to-date with main (updated as of Dec 16, 11:50AM Pakistan time)
  • Ensure Tutor-mfe v19 has been released before merging this PR so that GitLab pipeline for indigo does not cause any issues

Merge Option

  • Ensure "Merge Commit" option is used to merge the branch into master (Responsible: @DawoudSheraz ). This is needed to ensure the commit history when master is merged back into nightly

@hinakhadim hinakhadim marked this pull request as draft October 18, 2024 12:53
@hinakhadim hinakhadim marked this pull request as ready for review October 22, 2024 10:33
@DawoudSheraz DawoudSheraz changed the base branch from nightly to master November 6, 2024 13:42
@DawoudSheraz DawoudSheraz force-pushed the sumac branch 3 times, most recently from c57bfc3 to 640c46e Compare December 6, 2024 06:58
@DawoudSheraz DawoudSheraz merged commit fc4f231 into release Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants