-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting buggy behaviour while dynamic config #86
Comments
This chagne make it possible if this module was loaded **then** the configuration for studio url is changed, then it will pick the last value. More context overhangio/tutor-mfe/issues/86
Thanks for investigating this, @ghassanmas.
This would solve the URL problem, but I'd be concerned about scalability. This adds adds a little processing time to each request that hits Caddy, and we're talking about many more requests than just the initial configuration one. This could conceivably introduce a bottleneck to the deployment. And yes, there's the k8s question we'd have to look into. |
This chagne make it possible if this module was loaded **then** the configuration for studio url is changed, then it will pick the last value. More context overhangio/tutor-mfe/issues/86
This chagne make it possible if this module was loaded **then** the configuration for studio url is changed, then it will pick the last value. More context overhangio/tutor-mfe/issues/86
This change make it possible if LMS url to be changed, that the last value will be picked. This is simlair openedx/frontend-app-authoring/pull/389 which issue overhangio/tutor-mfe/issues/86, the fixes is needed so that dynamic config would work with tutor: overhangio/tutor-mfe/pull/69
This change make it possible if LMS url to be changed, that the last value will be picked. This is simlair openedx/frontend-app-authoring/pull/389 which issue overhangio/tutor-mfe/issues/86, the fixes is needed so that dynamic config would work with tutor: overhangio/tutor-mfe/pull/69
This change make it possible if LMS url to be changed, that the last value will be picked. This is simlair openedx/frontend-app-authoring/pull/389 which issue overhangio/tutor-mfe/issues/86, the fixes is needed so that dynamic config would work with tutor: overhangio/tutor-mfe/pull/69
This change make it possible if LMS url to be changed, that the last value will be picked. This is simlair openedx/frontend-app-authoring/pull/389 which issue overhangio/tutor-mfe/issues/86, the fixes is needed so that dynamic config would work with tutor: overhangio/tutor-mfe/pull/69
@ghassanmas, I'm closing this in favor of opening new issues for specific problems after #69 is merged. |
This change make it possible if LMS url to be changed, that the last value will be picked. This is simlair openedx/frontend-app-authoring/pull/389 which issue overhangio/tutor-mfe/issues/86, the fixes is needed so that dynamic config would work with tutor: overhangio/tutor-mfe/pull/69
This change make it possible if LMS url to be changed, that the last value will be picked. This is simlair openedx/frontend-app-authoring/pull/389 which issue overhangio/tutor-mfe/issues/86, the fixes is needed so that dynamic config would work with tutor: overhangio/tutor-mfe/pull/69
This change make it possible if LMS url to be changed, that the last value will be picked. This is simlair openedx/frontend-app-authoring/pull/389 which issue overhangio/tutor-mfe/issues/86, the fixes is needed so that dynamic config would work with tutor: overhangio/tutor-mfe/pull/69
This chagne make it possible if this module was loaded **then** the configuration for studio url is changed, then it will pick the last value. More context overhangio/tutor-mfe/issues/86
This chagne make it possible if this module was loaded **then** the configuration for studio url is changed, then it will pick the last value. More context overhangio/tutor-mfe/issues/86
Problematic configs
ACCESS_TOKEN_COOKIE_NAME
When this doesn't exists:
ACCESS_TOKEN_COOKIE_NAME:"edx-jwt-cookie-header-payload"
This occurs on frontend-app-learning when being authenticated, it will not occur if you browsing a course as anonymous.
STUDIO_BASE_URL
I found that course authoring doesn't take this key into consideration, though it makes call to mfe config, but nonetheless it doesn't affect.Solution Proposal
cms-api
and then create a proxy role simliar to the one for config api that proxycms-api
to =>STUDIO_BASE_URL
. One thing I am not sure about this approach is that how it would work with k8s, but in any case it uses the same principle of the how we proxy the config api.On a more general point, I think it would better to just create two proxy role, for the LMS and CMS such that always set a predifiend token for of both and then add proxy to lms/cms, instead of just adding proxy for dynamic config uri we set it at the sub/domain level.
The text was updated successfully, but these errors were encountered: