fix: Don't build uwsgi with xml support. #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
reviewed
Nov 13, 2024
There was a problem hiding this comment.
This seems to be one of the first ripple effects of the pending uwsgi deprecation... 😨
Since this is fixing a bug, can you please add a changelog entry? https://docs.tutor.edly.io/tutor.html#contributing
|
Since ubuntu PR was merged in nightly, this PR should be merged to nightly as well. Apart from changelog, you might want to rebase the branch on nightly. |
When uwsgi runs with xml support, it throws the following error on startup with the latest version of edx-platform: ``` xmlsec.InternalError: (-1, 'lxml & xmlsec libxml2 library version mismatch') ``` See xmlsec/python-xmlsec#320 for more details on this. Essentially, the uWSGI wheel is built against a different version of libxml2 and it causes this version mismach error when trying to load xmlsec. The xml support in uWSGI is only needed for runing with xml configuration files, which tutor does not do. Following the guidance of the above issue, I updated the `openedx` Dockerfile to no longer compile with any xml support as a part of the build. The time to build uWSGI was only slightly more than building from cache so I'm not concerned about major slowdowns in the build time for un-cached builds.
feanil
force-pushed
the
feanil/fix_uwsgi_xml_issues_master
branch
from
f1edbd9 to
8aba298
Compare
|
Added a changelog entry, let me know if you need anything else. |
changelog.d/20241113_131448_feanil_fix_uwsgi_xml_issues_master.md
Outdated
Show resolved
Hide resolved
DawoudSheraz
approved these changes
Nov 14, 2024
|
@regisb Can you take another look at this, please? Thanks |
regisb
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uwsgi runs with xml support, it throws the following error on startup with the latest version of edx-platform:
See xmlsec/python-xmlsec#320 for more details on this.
Essentially, the uWSGI wheel is built against a different version of libxml2 and it causes this version mismach error when trying to load xmlsec. The xml support in uWSGI is only needed for runing with xml configuration files, which tutor does not do. Following the guidance of the above issue, I updated the
openedxDockerfile to no longer compile with any xml support as a part of the build. The time to build uWSGI was only slightly more than building from cache so I'm not concerned about major slowdowns in the build time for un-cached builds.