Conversation
Contributor
Author
|
This is ready for review @overhangio/tutor-developers. Cc @ghassanmas. |
ghassanmas
reviewed
May 16, 2022
Member
ghassanmas
left a comment
ghassanmas
left a comment
There was a problem hiding this comment.
This will be applied for building the image in production and development right? if yes
I think for development using npm install would be a batter option (unless developer in development mode is not concnered about node_modules)
Contrary to what we might expect, `npm install` does not install pinned requirements from a project's package-lock.json. That's the responsibility of `npm ci`: https://docs.npmjs.com/cli/v8/commands/npm-ci Running `npm ci` is also *much* faster than `npm install`, so that's a huge win. See this issue for reference: openedx/wg-frontend#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to what we might expect,
npm installdoes not install pinnedrequirements from a project's package-lock.json. That's the responsibility of
npm ci: https://docs.npmjs.com/cli/v8/commands/npm-ciRunning
npm ciis also much faster thannpm install, so that's a huge win.See this issue for reference: openedx/wg-frontend#100