build: prepare Dockerfile for common/lib removal #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soon, running: pip install -r ./requirements/edx/base.txt in edx-platform will no longer install the local project (that is, `-e .`). To prepare for that change, we add the line: pip install -e . to the Dockerfile. This is backwards-compatible. More details: https://openedx.atlassian.net/browse/BOM-2575?focusedCommentId=613181
regisb
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Soon, running:
in edx-platform will no longer install the local
project (that is,
-e .). To prepare for that change,we add the line:
to the Dockerfile. This is backwards-compatible.
More details:
https://openedx.atlassian.net/browse/BOM-2575?focusedCommentId=613181
Additional Info
This change will be necessary for Tutor as soon as openedx/edx-platform#30890 merges.
Once both PRs merge, we will be all set to refactor Tutor's Dockerfile so that code changes don't require re-installation of requirements.