-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename quickstart to launch #724
Merged
regisb
merged 1 commit into
overhangio:nightly
from
Carlos-Muniz:Carlos-Muniz/rename-quickstart-to-launch
Sep 30, 2022
Merged
feat: rename quickstart to launch #724
regisb
merged 1 commit into
overhangio:nightly
from
Carlos-Muniz:Carlos-Muniz/rename-quickstart-to-launch
Sep 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2022
@regisb This and associated PRs are ready for review.
|
regisb
requested changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thrilled to see this!
9743360
to
af453e9
Compare
`quickstart` is being renamed to `launch` and deprecated in favor of using `launch`. The `quickstart` function temporarily aliases to `launch`. Further mentions of `quickstart` have been changed to reference `launch` instead. docs: replace quickstart mentions with launch Most mentions of quickstart have been renamed to reference launch, as part of the renaming task. `quickstart.rst` has been renamed to `launch.rst` in order to maintain consistency. TODO: create new gifs for `tutor <mode> launch` to replace the ones that use `tutor <mode> quickstart`. fix: correct indenting of quickstart functions docs: add to nightly changelog fix: correct the formatting to pas test-format docs: update quickstart installation as launch docs: un-rename launch back to quickstart Launch was renamed to quickstart, but that may be confusing. It has been un-renamed back to quickstart. fix: call the launch click command the right way Calls the launch click command via context.invoke(launch, *args, **kwargs). See https://click.palletsprojects.com/en/7.x/api/#click.Context.invoke docs: add 💥 to CHANGELOG-nightly.md entry We are indicating that this change is breaking 💥 to encourage people to migrate their scripts right away!
ee96c27
to
e98a00b
Compare
regisb
approved these changes
Sep 30, 2022
@Carlos-Muniz FYI the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes renames all mentions of
quickstart
tolaunch
found in the code and documentation.
Acceptance Criteria:
This PR is related to the following PRs:
Closes openedx-unsupported/wg-developer-experience#53