Skip to content

fix: add a temporary patch for the fix of cache programs command error#862

Merged
regisb merged 3 commits intooverhangio:palmfrom
edly-io:fix/faraz-add_temporary_patch_for_cache_program_command_issue_for_discovery
Jun 20, 2023
Merged

fix: add a temporary patch for the fix of cache programs command error#862
regisb merged 3 commits intooverhangio:palmfrom
edly-io:fix/faraz-add_temporary_patch_for_cache_program_command_issue_for_discovery

Conversation

@Faraz32123
Copy link
Contributor

This PR is created as temporary fix for cache programs command that is used in tutor-discovery plugin to cache programs.
The issue link is here.

@Faraz32123
Copy link
Contributor Author

@regisb , you can review it.

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can you please add a changelog entry? https://docs.tutor.overhang.io/tutor.html#contributing

@Faraz32123
Copy link
Contributor Author

Faraz32123 commented Jun 20, 2023

@regisb this PR may not be needed now, as the change is merged in open-release/palm.master branch of edx-platform.
So, should I close this PR and tutor-discovery plugin's issue?

@regisb
Copy link
Contributor

regisb commented Jun 20, 2023

We still need this PR, because tutor does not run Open edX from the open-release/palm.master branch, but from the open-release/palm.1 tag.

@Faraz32123 Faraz32123 requested a review from regisb June 20, 2023 13:27
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!

@regisb regisb merged commit 998c5b4 into overhangio:palm Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments