Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make change filters optional #277

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix: make change filters optional #277

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cf3c9f
fix: make change filters optional
getinnocuous Oct 29, 2024
eaaa9e3
Update changes.proto
getinnocuous Oct 30, 2024
8f50343
Merge branch 'main' into change-filters-optional
getinnocuous Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions changes.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ message GetAppSummariesResponse {

message ListHomeChangesRequest {
PaginationRequest pagination = 1;
ChangeFiltersRequest filters = 2;
optional ChangeFiltersRequest filters = 2;
}

message ChangeFiltersRequest {
Expand All @@ -278,7 +278,7 @@ message ChangeFiltersRequest {
repeated Risk.Severity risks = 3;
repeated string authors = 4;
repeated ChangeStatus statuses = 5;
SortOrder sortOrder = 6;
getinnocuous marked this conversation as resolved.
Show resolved Hide resolved
optional SortOrder sortOrder = 6;
}

message ListHomeChangesResponse {
Expand Down
Loading