Feature/proper about window #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@overtake I’d love to hear what you think about this PR. If it’s a flat-out rejection, that’s totally fine—please let me know so I can make any changes you’d like, or just move on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a proper macOS About window to this application, which:
Right now, it is properly translated for English. I have no idea how the Telegram translation framework works, and I would greatly appreciate guidance on how to implement it so that people who read other languages can benefit from this change as well.
Is this PR acceptable? Have I matched the code style? I would love to see this implemented, so if there's anything you don't like about how I've done it, please let me know so I can improve it :3