-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup python codes #429
base: master
Are you sure you want to change the base?
cleanup python codes #429
Conversation
buildbox/appdiff.py
Outdated
def remove_plugin_files(files): | ||
result = set() | ||
excluded = set() | ||
for f in files: | ||
if False and re.match('PlugIns/.*', f): | ||
# if re.match('PlugIns/.*', f): | ||
if False: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about d82db8a ?
I try to keep some comments in case of adding them back in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, because this second set isn't used anymore, refactoring of functions that use remove_plugin_files could be even better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for confirming, I can delete this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, I didn't see that this function essentially does nothing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the deleting should be as simple as b1c7c76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any thought we could move forward?
any thought we could move forward? thanks |
simplify some python codes