Selenium Tests #162
Open
Selenium Tests #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I left a few comments:
- some xpaths are a bit too specific and will break easily if we change anything in the layout, so it's generally better to find a unique element (e.g. because of a class/id) near the one you want and then go from there, instead of starting from the root;
- there are some wait/sleep that look a bit fragile: if the server takes longer the test will timeout and fail, if it takes less time it will wait for nothing. If possible it would be better to wait for the next page load (if selenium has such event) or possibly polling every few seconds.
- there were a few style issues (e.g. lines too long, some spacing, string concatenation instead of f-string)
P.S.: using 3.10+ features is fine with me.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
| ======= | ||
| driver.find_element(By.ID, 'guest-login').click() | ||
|
|
||
| >>>>>>> Stashed changes |
There was a problem hiding this comment.
It seems that some merge markers were accidentally committed (probably after a merge).
There was a problem hiding this comment.
The commit after this one fixed this I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first commit for adding Selenium tests to the front end. This test runs the SAM preset with a custom day count and process count sent by the user through cli args.
This version currently only supports Chrome and is using some Python 3.10+ only features, i.e.
matchcase for the initial compare. This can be changed to if else statements to not break any compatibility with older versions. It is a rudimentary implementation ofmatchand can be easily expanding upon.Work for adding Firefox and Edge support are next.