Score no such key issue #324 #345
Merged
+21
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneubank
approved these changes
Mar 6, 2023
Merged
justincorrigible
pushed a commit
that referenced
this pull request
Mar 6, 2023
justincorrigible
pushed a commit
that referenced
this pull request
Mar 6, 2023
UmmulkiramR
added a commit
that referenced
this pull request
Mar 6, 2023
* add test branch deployability * Score no such key issue #324 (#345) * code fix for the NoSuchKey issue encountered when uploading large files. * added custom branch name to test changes * removed custom branch tag --------- Co-authored-by: UmmulkiramR <urangwala@oicr.on.ca> * release 5.8.2 - bug fix for issue #324 * merge-back versioning from prod --------- Co-authored-by: Anders Richardsson <2107110+caravinci@users.noreply.github.com> Co-authored-by: UmmulkiramR <urangwala@oicr.on.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final step (a call to the finalizeUpload() method) of the upload command deletes all the uploaded parts of the file. But while the finalizing of the uploaded parts is still in progress score client keeps retrying the the call to finalizeUpload() and since the uploaded parts are being deleted a '404 Not found NoSuchKey' response is returned from Amazon S3.
As a '404 Not found' indicates the parts have been or are being deleted, which is what the method is supposed to do, a retried call to finalizeUpload() will not return an exception.