Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc/5.9.0 #365

Merged
merged 9 commits into from
May 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF S

<groupId>bio.overture</groupId>
<artifactId>score</artifactId>
<version>5.8.4</version>
<version>5.9.0</version>
<packaging>pom</packaging>
<name>${project.artifactId}</name>
<description>${project.name}</description>
Expand Down
4 changes: 2 additions & 2 deletions score-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF S
<parent>
<groupId>bio.overture</groupId>
<artifactId>score</artifactId>
<version>5.8.4</version>
<version>5.9.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down Expand Up @@ -252,7 +252,7 @@ ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF S

<!-- Versions - Genomics -->
<!-- <htsjdk.version>1.138</htsjdk.version> -->
<htsjdk.version>2.1.0</htsjdk.version>
<htsjdk.version>2.16.0</htsjdk.version>

<!-- Versions - FUSE -->
<javafs.version>0.1.0</javafs.version>
Expand Down
1 change: 0 additions & 1 deletion score-client/src/main/bin/score-client
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ CLIENT_DIR="$(cd ${BASE_DIR} && pwd -P)"
exec java -Xmx3G \
--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED \
--add-opens=java.base/java.nio=ALL-UNNAMED \
--illegal-access=deny \
-Dlogging.path=${BASE_DIR}/logs \
-Dspring.config.additional-location=${CLIENT_DIR}/conf/ \
-Dlogging.config=${CLIENT_DIR}/conf/logback.xml \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import bio.overture.score.client.exception.BadManifestException;
import bio.overture.score.client.metadata.EntityNotFoundException;
import com.beust.jcommander.*;
import htsjdk.samtools.util.Log;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import lombok.val;
Expand Down Expand Up @@ -89,6 +90,8 @@ public class ClientMain implements CommandLineRunner {

public static void main(String[] args) {
try {
Log.setGlobalLogLevel(Log.LogLevel.ERROR);

// Bootstrap
val profiles = bootstrap(args);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ private void validateParms() {
}

checkParameter(objectId != null || sequenceFile != null || manifestResource != null,
"One of --object-id, --input-file or --manifest must be specified");
"One of --object-id, --input-file or --manifest must be specified. " +
"For CRAM files, please additionally include --reference-file.");

if (objectId == null && sequenceFile == null) {
checkParameter(manifestResource != null && outputDir != null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ public SamFileBuilder getBuilder(@NonNull SeekableStream inputStream, SeekableSt
// Since CRAM is a compressed form of BAM file that saves space by only recording
// the differences between an individual BAM file and a standard reference file.
// we need to have the reference file in order to decode the CRAM file.
if(referenceFile == null){
throw new RuntimeException("CRAM file type detected, an indexed (fai) reference file (fa, fasta) must be provided. Please specify via --reference-file.");
}
val reference = new ReferenceSource(referenceFile);
val primitiveReader = new CRAMFileReader(inputStream, indexStream,reference, ValidationStringency.DEFAULT_STRINGENCY);
val reader = new SamReader.PrimitiveSamReaderToSamReaderAdapter(
Expand Down
2 changes: 1 addition & 1 deletion score-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF S
<parent>
<groupId>bio.overture</groupId>
<artifactId>score</artifactId>
<version>5.8.4</version>
<version>5.9.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion score-fs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF S
<parent>
<groupId>bio.overture</groupId>
<artifactId>score</artifactId>
<version>5.8.4</version>
<version>5.9.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion score-server/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF S
<parent>
<groupId>bio.overture</groupId>
<artifactId>score</artifactId>
<version>5.8.4</version>
<version>5.9.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion score-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF S
<parent>
<groupId>bio.overture</groupId>
<artifactId>score</artifactId>
<version>5.8.4</version>
<version>5.9.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down