-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releas Candidate 5.10.1 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix conjars repo to exclude * score test disable conjars repo * conjars repository id * mirror conjars * add comment * remove maven profiler extension
using fmt-maven-plugin to format code
Updated Slack link
Update Jenkinsfile
Fix related to eliminating the dcc Dependencies and unsed tests from the code
S3 Service using API instead of .meta file
Refactor S3 Bucket Name Retrieval Method
…d Bucket Methods (#409) * Refactor S3 Bucket Name Retrieval Method * Improve Handling of Empty and Whitespace Parameters in Key, MetaKey, and Bucket Methods
…ilable (#413) * Refactor S3 Bucket Name Retrieval Method * Object Retrieval: Support for Multipart Uploads * Used getContentLength() from the ObjectMetaData to Calculate the part * Update Part.java Reverting changes related to Part.java * Handle case where external=false and length < 0 --------- Co-authored-by: AzherAliMohammed <68929005+AzherAliMohammed@users.noreply.github.com> Co-authored-by: Jon Eubank <joneubank@gmail.com>
* Retrieve MD5 from object metadata * Decode Base64 formatted contentMD5 value
justincorrigible
approved these changes
Jun 27, 2024
leoraba
reviewed
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
leoraba
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This release includes a new feature to allow Score servers to handle downloading files from an S3 backend when the .meta file describing a file upload is not found. In normal operation, this feature will have no impact on Score servers. If for any reason the Score-generated .meta files cannot be found, then the download service will calculate the available parts and file description from the S3 object metadata. In particular, the object MD5 can now be read either from the built-in S3 API's ContentMD5 property, or in a custom user Metadata field. This provides more flexibility for Score to serve files that were not originally uploaded to the S3 server through the Score upload CLI. This also makes it download from S3 objects that were transferred from an Azure instance to S3.
One additional change is included that removes Score's dependency on ICGC specific Java packages. The related code has been added to the Score Core package.
Included Changes