Improve multiple crop zone support #1850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amends handling of the 'crop' render option such that when multiple crop zones are specified, one CroppedRegionSet with many crop zones is used rather than many CroppedRegionSets each with one crop zone. This resolves issues where crop zones within the same render could clobber each others tiles if close enough and could be rendered with a different number of zoom levels.
Auron956
force-pushed
the
crop-changes
branch
from
241ce6e
to
cdb0b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes how multiple crop zones within a single render definition are handled, resolving an issue where output would be corrupted when crop zones overlapped or were in close proximity to each other (potentially fixes #1848).
See below a comparison of the same render on master at 91ea874 (top) and this PR (bottom) with two crop zones defined as
[(-1264, -112, -1249, -65), (-1328, -144, -1265, -113)]: