Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OAuth2 support #79

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat: add OAuth2 support #79

merged 1 commit into from
Apr 16, 2024

Conversation

rbeuque74
Copy link
Member

Resolves #76

@rbeuque74 rbeuque74 self-assigned this Dec 22, 2023
@rbeuque74 rbeuque74 mentioned this pull request Dec 22, 2023
Closed
c-roussel
c-roussel reviewed Jan 8, 2024
View reviewed changes
ovh/configuration.go Outdated Show resolved Hide resolved
ovh/ovh.go Show resolved Hide resolved
ovh/ovh.go Outdated Show resolved Hide resolved
deathiop
deathiop reviewed Jan 8, 2024
View reviewed changes
ovh/configuration_test.go Outdated Show resolved Hide resolved
@rbeuque74 rbeuque74 marked this pull request as ready for review March 29, 2024 17:09
@amstuta
Copy link
Contributor

amstuta commented Apr 2, 2024

We should add something in the README to mention this authentication method, otherwise all good

deathiop
deathiop reviewed Apr 2, 2024
View reviewed changes
ovh/ovh.go Outdated Show resolved Hide resolved
deathiop
deathiop reviewed Apr 2, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@deathiop
Copy link
Contributor

deathiop commented Apr 2, 2024

We should probably have a few tests with httpmock mocking success and failure from the OAuth2 token URL

@rbeuque74 rbeuque74 force-pushed the oauth2 branch 2 times, most recently from 73ba5a1 to 1ba0758 Compare April 3, 2024 17:13
@rbeuque74 rbeuque74 requested a review from deathiop April 3, 2024 17:14
amstuta
amstuta previously approved these changes Apr 5, 2024
View reviewed changes
deathiop
deathiop reviewed Apr 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
deathiop
deathiop reviewed Apr 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
deathiop
deathiop reviewed Apr 10, 2024
View reviewed changes
ovh/ovh_test.go Outdated Show resolved Hide resolved
@rbeuque74
feat: add OAuth2 support
fa48fc7 
Resolves #76

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
@deathiop deathiop merged commit 18be085 into master Apr 16, 2024
7 checks passed
@deathiop deathiop deleted the oauth2 branch April 16, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amstuta amstuta amstuta approved these changes

@deathiop deathiop deathiop approved these changes

@c-roussel c-roussel Awaiting requested review from c-roussel

@a-beudin a-beudin Awaiting requested review from a-beudin

@mxpetit mxpetit Awaiting requested review from mxpetit

Assignees

@rbeuque74 rbeuque74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: add support for oauth2 access token authentication
4 participants
@rbeuque74 @amstuta @deathiop @c-roussel