fix(Api.php) : handle 204 no content response in decodeResponse #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OctaYann
requested review from
rbeuque74,
deathiop,
a-beudin,
amstuta and
mxpetit
as code owners
|
I'm referencing to this issue #140 |
Signed-off-by: OctaYann <yann@octacom.fr>
|
Hi there, This ended up handled in #142 (returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Ovh api now send a 204 no content response when you call /domain/zone/{zoneName}/refresh endpoint.
Problem:
Api.php\decodeResponse method throw a error by default when it fail to decode json, and so when you pass empty string from no content reponse
Proposal:
ruturn empty array when response has code 204 or body length is 0
All tests are passing, hope this can be merged fast.
Thanks !