feat: handle allowedIPs parameters in CK building #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathiop
requested review from
rbeuque74,
a-beudin,
amstuta and
mxpetit
as code owners
deathiop
force-pushed
the
allowed-ips
branch
3 times, most recently
from
6e9fb5d
to
3702104
Compare
deathiop
commented
Jun 7, 2024
ovh/client.py
Outdated
| """ | ||
| Create a new "consumer key" identifying this application's end user. API | ||
| will return a ``consumerKey`` and a ``validationUrl``. The end user must | ||
| visit the ``validationUrl``, authenticate and validate the requested | ||
| ``access_rules`` to link his account to the ``consumerKey``. Once this | ||
| is done, he may optionally be redirected to ``redirect_url`` and the | ||
| application can start using the ``consumerKey``. | ||
| application can start using the ``consumerKey``. If adding a ``allowedIPs`` |
There was a problem hiding this comment.
Suggested change
| application can start using the ``consumerKey``. If adding a ``allowedIPs`` | |
| application can start using the ``consumerKey``. If adding an ``allowedIPs`` |
deathiop
commented
Jun 7, 2024
ovh/client.py
Outdated
| """ | ||
| Create a new "consumer key" identifying this application's end user. API | ||
| will return a ``consumerKey`` and a ``validationUrl``. The end user must | ||
| visit the ``validationUrl``, authenticate and validate the requested | ||
| ``access_rules`` to link his account to the ``consumerKey``. Once this | ||
| is done, he may optionally be redirected to ``redirect_url`` and the | ||
| application can start using the ``consumerKey``. | ||
| application can start using the ``consumerKey``. If adding a ``allowedIPs`` | ||
| parameter, the generated credentials will only be usable from these IPS. |
There was a problem hiding this comment.
Suggested change
| parameter, the generated credentials will only be usable from these IPS. | |
| parameter, the generated credentials will only be usable from these IPs. |
Signed-off-by: Adrien Barreau <adrien.barreau@ovhcloud.com>
amstuta
previously approved these changes
Jun 7, 2024
Signed-off-by: Adrien Barreau <adrien.barreau@ovhcloud.com>
amstuta
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.