Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endpoint url in documentation and in client.py #70

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Fix endpoint url in documentation and in client.py #70

merged 1 commit into from
Dec 10, 2018

Conversation

UmBsublime
Copy link

Hi please consider and merge this PR

@UmBsublime
Copy link
Author

Tests seem to be failing for unrelated reasons. I also think that once this is merged it should be released ASAP

Signed-off-by: Charles Vaillancourt <charles.vaillancourt@corp.ovh.com>
Copy link
Member

@rbeuque74 rbeuque74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbeuque74
Copy link
Member

Failing tests due to #68 (will be resolved in #71), merging.

@rbeuque74 rbeuque74 merged commit 6d4e840 into ovh:master Dec 10, 2018
@rbeuque74 rbeuque74 mentioned this pull request Dec 10, 2018
@UmBsublime UmBsublime deleted the Fix-US-endpoint branch December 14, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants