Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
It seems that passing
hostname
to Datadog doesn't get translated intohost
on their end.See this screenshot where
hostname
is passed in the data object of the log, but not shown in the log entry - it sayssimons-mbp-2.lan
.For the other log I have applied my change in this PR, and we can see that
host
in the log entry corresponds to what I sent ashost
in the data object:In order to not break the API, we can still have
hostname
parameter untouched, but also allow it to behost
to align with Datadog's naming.This is the test output. Please advise if you want it in any other format.
Checklist
npm run test