Replace j2 for jinjanate #4018
Merged
Replace j2 for jinjanate #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecastillolema
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
|
@josecastillolema can you please sign-off the commit? ( |
josecastillolema
force-pushed
the
jinjanate
branch
from
2f7c357 to
c78cf16
Compare
Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>
josecastillolema
force-pushed
the
jinjanate
branch
from
c78cf16 to
652f4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: josecastillolema josecastillolema@gmail.com
- What this PR does and why is it needed
j2 dependency uses the imp module which has been deprecated since Python 3.4 and removed in 3.12 (see kolypto/j2cli#80).
j2 authors have published Jinjanator as the new alternative, which resolves this issue by adding a much more flexible and less invasive plugin mechanism.
Closes #4011
- How to verify it
Manually verified on Python 3.12.0.
Should be tested in previous Python versions (guess the CI will already do that?)
- Description for the changelog
Python 3.12 support by replacing j2 for jinjanate