Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: pass Context to client functions that call rpc2's Call() #208

Merged
merged 2 commits into from
Jul 28, 2021
Merged

client: pass Context to client functions that call rpc2's Call() #208

merged 2 commits into from
Jul 28, 2021

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Jul 28, 2021

No description provided.

@dcbw
vendor: bump github.com/cenkalti/rpc2
771d9ef 
To c1acbc6ec984b7ae6830b6a36b62f008d5aefc4c

Signed-off-by: Dan Williams <dcbw@redhat.com>
@dcbw
client: pass Context to client functions that call rpc2's Call()
a6498a7 
Let users of libovsdb pass a Context to functions that will block
on the OVS database so they can set a timeout.

Signed-off-by: Dan Williams <dcbw@redhat.com>
@dcbw
Copy link
Contributor Author

dcbw commented Jul 28, 2021

@dave-tucker @trozet

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1076400978

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.316%
Totals Coverage Status
Change from base Build 1075256139: 0.0%
Covered Lines: 3290
Relevant Lines: 4311
💛 - Coveralls

dave-tucker
dave-tucker approved these changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave-tucker dave-tucker merged commit b3fff3e into ovn-org:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-tucker dave-tucker dave-tucker approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcbw @coveralls @dave-tucker