Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Filter immutable fields from Update #210

Merged
merged 1 commit into from
Oct 1, 2021
Merged

client: Filter immutable fields from Update #210

merged 1 commit into from
Oct 1, 2021

Conversation

dave-tucker
Copy link
Collaborator

Fixes: #203

Signed-off-by: Dave Tucker dave@dtucker.co.uk

@dave-tucker dave-tucker added the fix label Aug 3, 2021
@coveralls
Copy link

coveralls commented Aug 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1295129362

  • 18 of 24 (75.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 75.547%
Changes Missing Coverage Covered Lines Changed/Added Lines %
client/api.go 18 24 75.0%
Files with Coverage Reduction New Missed Lines %
client/client.go 2 72.64%
server/monitor.go 2 90.91%
server/transact.go 6 59.61%
Totals Coverage Status
Change from base Build 1294717369: -0.2%
Covered Lines: 3485
Relevant Lines: 4613
💛 - Coveralls

amorenoz
amorenoz reviewed Aug 4, 2021
View reviewed changes
client/api.go Show resolved Hide resolved
@jcaamano jcaamano mentioned this pull request Sep 28, 2021
Merged
@dave-tucker
client: Filter immutable fields from Update
cf4fcb5 
Fixes: ovn-org#203

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker dave-tucker merged commit e29d8bd into ovn-org:main Oct 1, 2021
@jcaamano jcaamano mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorenoz amorenoz amorenoz left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client.Update does not prune immutable fields
3 participants
@dave-tucker @coveralls @amorenoz