client: Monitor fallback only on unsupported rpc #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1343322902
💛 - Coveralls |
dave-tucker
force-pushed
the
fix-monitor-fallback
branch
from
45d12ea
to
c60a132
Compare
dave-tucker
force-pushed
the
fix-monitor-fallback
branch
from
c60a132
to
7868349
Compare
Falling back to a previous version of the monitor RPC should only happen if we get a `unsupported rpc` error from ovsdb-server. Previously we would fall back on `context deadline exceeded` which is not expected behaviour Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
dave-tucker
force-pushed
the
fix-monitor-fallback
branch
from
7868349
to
12f9d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falling back to a previous version of the monitor RPC should only happen
if we get a
unsupported rpcerror from ovsdb-server. Previously wewould fall back on
context deadline exceededwhich is not expectedbehaviour
Signed-off-by: Dave Tucker dave@dtucker.co.uk