Fix missing change name ovn central in function start-ovn-ic #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function start-ovn-ic must check if OVN_DB_CLUSTER is being used to set CENTRAL_IC_ID name. Running the following command, you will see the problem: OS_BASE=ubuntu OS_IMAGE=docker.io/library/ubuntu:jammy ENABLE_SSL=no CENTRAL_COUNT=1 GW_COUNT=4 CHASSIS_COUNT=4 ./ovn_cluster.sh start It creates ovn central with name ovn-central-az1, and function try to use ovn-central-az1-1 Signed-off-by: Lucas Vargas Dias <lucas.vdias@luizalabs.com>
|
Hi @numansiddique could you review it? Thanks |
|
Hi @lucassdiass! Sorry for the delayed reply. Doesn't #93 fix your problem? I just tried starting a cluster in the way you described with the code that's currently on the main branch and it worked fine. Thanks, |
Hi, It works. When I made PR this fix didn't exist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function start-ovn-ic must check if OVN_DB_CLUSTER is being used to set CENTRAL_IC_ID name.
Running the following command, you will see the problem: OS_BASE=ubuntu OS_IMAGE=docker.io/library/ubuntu:jammy ENABLE_SSL=no CENTRAL_COUNT=1 GW_COUNT=4 CHASSIS_COUNT=4 ./ovn_cluster.sh start
It creates ovn central with name ovn-central-az1, and function try to use ovn-central-az1-1