Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libovsdb] WIP: Use libovsdb for acls & portgroups operations #2353

Closed

Conversation

jcaamano
Copy link
Contributor

@jcaamano jcaamano commented Jul 21, 2021

Depends on #2369 && ovn-org/libovsdb#207

@jcaamano jcaamano force-pushed the libovsdb-policy-feature branch 2 times, most recently from 0d8c064 to 3aba3e6 Compare July 22, 2021 13:22
@jcaamano
Copy link
Contributor Author

Current status is: code done, unit tests not done:

  • addAlllowNodeACL tests don't pass because of dependency migrating logical switch to libovsdb
  • Policy unit tests need work but got enough of them working to be fairly sure it is just a mechanical matter of mapping fake exec/goovn mocks to libovsdb test server data.

@jcaamano jcaamano force-pushed the libovsdb-policy-feature branch 3 times, most recently from 47eb7e7 to 634fae5 Compare July 28, 2021 09:06
@jcaamano jcaamano changed the title WIP: Use libovsdb for acls & portgroups operations [libovsdb] WIP: Use libovsdb for acls & portgroups operations Jul 28, 2021
@jcaamano jcaamano force-pushed the libovsdb-policy-feature branch 3 times, most recently from 1658ee9 to fd1e39e Compare July 30, 2021 16:58
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Fixes libovsdb test harness assuming empty strings are named uuids. Also
a bit more thorough detecting duplicate named uuids and duplicate
unexpected matches between actual and expected when attempting to infer
them.

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@dcbw
Copy link
Contributor

dcbw commented Oct 7, 2021

@jcaamano I think we can close this now, right?

@jcaamano jcaamano closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants