Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to not store records internally in the actor #129

Merged
merged 1 commit into from
May 9, 2019

Conversation

vlovgr
Copy link
Contributor

@vlovgr vlovgr commented May 8, 2019

This pull request changes KafkaConsumerActor to not store records internally when records are received for partitions for which there are no requests. Instead, we change to poll(Duration.Zero) when there are no requests. This avoids assignment and records to be returned in one poll, which is the cause for 'records for partitions without requests'. This is also similar to what Alpakka Kafka does, which seems to have worked there. We add checks to make sure nothing unexpected is received.

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #129 into 0.20.x will increase coverage by 0.39%.
The diff coverage is 79.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.20.x     #129      +/-   ##
==========================================
+ Coverage   93.35%   93.75%   +0.39%     
==========================================
  Files          40       40              
  Lines        1174     1153      -21     
  Branches       80       78       -2     
==========================================
- Hits         1096     1081      -15     
+ Misses         78       72       -6
Impacted Files Coverage Δ
src/main/scala/fs2/kafka/internal/LogEntry.scala 25% <ø> (-1.48%) ⬇️
.../scala/fs2/kafka/internal/KafkaConsumerActor.scala 84.5% <79.06%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8400d62...d941864. Read the comment docs.

@vlovgr vlovgr merged commit 75ef99f into 0.20.x May 9, 2019
@vlovgr vlovgr deleted the no-internal-storage branch May 9, 2019 08:56
vlovgr pushed a commit that referenced this pull request Aug 29, 2019
@vlovgr vlovgr mentioned this pull request Aug 29, 2019
vlovgr added a commit that referenced this pull request Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant