Change to not store records internally in the actor #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes
KafkaConsumerActor
to not store records internally when records are received for partitions for which there are no requests. Instead, we change topoll(Duration.Zero)
when there are no requests. This avoids assignment and records to be returned in onepoll
, which is the cause for 'records for partitions without requests'. This is also similar to what Alpakka Kafka does, which seems to have worked there. We add checks to make sure nothing unexpected is received.