Edge fields extension and cluster undeployment improvement for edge #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ankicabarisic
commented
Nov 27, 2024
ankicabarisic
commented
- extending the edge to reflect node candidate properties
- including fpga, gpu, cpuFrequency
- removing edge node source during the cluster removal
- promoting jobId change during cluster removal
|
The quality check is failing as the JSON field properties are moved to the constants to be reused and for easy maintainance. I guess we can ignore this quality check for this PR. |
AlexFalessi
approved these changes
Nov 27, 2024
sal-common/src/main/java/org/ow2/proactive/sal/model/EdgeDefinition.java
Outdated
Show resolved
Hide resolved
sal-common/src/main/java/org/ow2/proactive/sal/model/EdgeDefinition.java
Outdated
Show resolved
Hide resolved
sal-common/src/main/java/org/ow2/proactive/sal/model/EdgeNode.java
Outdated
Show resolved
Hide resolved
sal-common/src/main/java/org/ow2/proactive/sal/model/Hardware.java
Outdated
Show resolved
Hide resolved
sal-common/src/main/java/org/ow2/proactive/sal/model/Hardware.java
Outdated
Show resolved
Hide resolved
sal-common/src/main/java/org/ow2/proactive/sal/model/LoginCredential.java
Outdated
Show resolved
Hide resolved
sal-common/src/main/java/org/ow2/proactive/sal/model/NodeCandidate.java
Outdated
Show resolved
Hide resolved
sal-common/src/main/java/org/ow2/proactive/sal/model/NodeProperties.java
Outdated
Show resolved
Hide resolved
sal-common/src/main/java/org/ow2/proactive/sal/model/NodeProperties.java
Outdated
Show resolved
Hide resolved
Comment on lines
139
to
144
| public Long getRam() { | ||
| return ram; | ||
| } | ||
|
|
||
| public void setMemory(Long memory) { | ||
| this.memory = memory; | ||
| public void setRam(Long memory) { | ||
| this.ram = memory; |
There was a problem hiding this comment.
Same. You can do that for every simple getter and setter.
I'll stop adding these kind of comments now.
There was a problem hiding this comment.
thanks for this, I changed all model classes i was updating in this PR to use Lombok getters, setters and equal and hash. Probably same should be done for other classes in model but will let it for another time :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.