Error handling for get cloud image calls #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
||
| try { | ||
| connection = (HttpURLConnection) requestUri.toURL().openConnection(); | ||
| connection.setRequestMethod(HttpMethod.GET.toString()); |
There was a problem hiding this comment.
A minor comment. At this point, we can check whether the connection is null, before going further with a null connection.
nebilbenmabrouk
approved these changes
Jul 22, 2024
fviale
pushed a commit
that referenced
this pull request
Aug 12, 2024
* intoducing unique IAAS infrastracture for cloud providers * processing IAAS get cloud images error so it return the Internal Server Error * remove authorisation exception (cherry picked from commit bdb072f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is resolved:
-> when the images can't be retrived the error is logged and send back to caller - previously it was retrurning empty set or even images from another clouds
-> cloud infrastructures are now created with unique infrastructure ID when IAAS connector is called to create them
Expected behavior with problematic clouds: