Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexes to improve performance #19

Closed
caffix opened this issue Jul 31, 2023 · 0 comments
Closed

Indexes to improve performance #19

caffix opened this issue Jul 31, 2023 · 0 comments
Assignees
@rynmrtn
Labels
enhancement New feature or request

Comments

@caffix
Copy link
Contributor

caffix commented Jul 31, 2023 •
edited by rynmrtn
Loading

Rather than guessing which indexes would be most valuable in the initial releases of asset-db, we left them out so that we could discover what indexes would be most valuable as postgres and sqlite databases grew in size.

After the release of Amass 4.x, we have concrete evidence of where indexes will be most valuable:

  • content.Name for FQDN asset types
  • assets.type
  • assets.last_seen, relations.last_seen
  • assets.created_at, relations.created_at
  • relations.type
@caffix caffix added the bug Something isn't working label Jul 31, 2023
@rynmrtn rynmrtn changed the title Index the FQDN Asset content.Name Indexes to improve performance Aug 3, 2023
@caffix caffix added enhancement New feature or request and removed bug Something isn't working labels Aug 3, 2023
rynmrtn added a commit to rynmrtn/asset-db that referenced this issue Aug 3, 2023
@rynmrtn
feat: add indexes to assets and relations tables
4304d2e 
- Index on `$.content.Name` for FQDN assets
- index on assets.type
- index on assets.last_seen
- index on relations.last_seen

Closes owasp-amass#19
@rynmrtn rynmrtn mentioned this issue Aug 3, 2023
Closed
rynmrtn added a commit to rynmrtn/asset-db that referenced this issue Aug 4, 2023
@rynmrtn
feat: add indexes to assets and relations tables
fbf0f7d 
- Index on `$.content.Name` for FQDN assets
- index on assets.type
- index on assets.last_seen
- index on relations.last_seen

Closes owasp-amass#19
@rynmrtn rynmrtn mentioned this issue Aug 4, 2023
Closed
rynmrtn added a commit to rynmrtn/asset-db that referenced this issue Aug 5, 2023
@rynmrtn
feat: add indexes to assets and relations tables
4e3903c 
- Index on `$.content.Name` for FQDN assets
- index on assets.type
- index on assets.last_seen
- index on relations.last_seen

Closes owasp-amass#19
@rynmrtn rynmrtn mentioned this issue Aug 5, 2023
Closed
rynmrtn added a commit to rynmrtn/asset-db that referenced this issue Aug 5, 2023
@rynmrtn
feat: add indexes to assets and relations tables
fb72543 
- Index on `$.content.Name` for FQDN assets
- index on assets.type
- index on assets.last_seen
- index on relations.last_seen

Closes owasp-amass#19
rynmrtn added a commit to rynmrtn/asset-db that referenced this issue Aug 17, 2023
@rynmrtn
feat: add indexes to assets and relations tables
a1e85ff 
- Index on `$.content.Name` for FQDN assets
- index on assets.type
- index on assets.last_seen
- index on relations.last_seen

Closes owasp-amass#19
@rynmrtn rynmrtn mentioned this issue Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rynmrtn rynmrtn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add indexes to assets and relations tables rynmrtn/asset-db
2 participants
@rynmrtn @caffix