Feature/lief15 #111
Merged
Feature/lief15 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
|
Thanks @timmyteo. Could you do retest once more, since pushed some commits since your review. |
prabhu
commented
Jul 27, 2024
| @@ -451,7 +452,7 @@ def process_pe_resources(parsed_obj): | |||
| "has_manifest": rm.has_manifest, | |||
| "has_string_table": rm.has_string_table, | |||
| "has_version": rm.has_version, | |||
| "manifest": (rm.manifest.replace("\\xef\\xbb\\xbf", "") if rm.has_manifest else None), | |||
| "manifest": (rm.manifest.replace("\\xef\\xbb\\xbf", "").removeprefix("\ufeff") if rm.has_manifest else None), | |||
There was a problem hiding this comment.
This removes the byte order mark
prabhu
commented
Jul 27, 2024
blint/binary.py
Outdated
| "verification_flags": str(parsed_obj.verify_signature()).replace( | ||
| "VERIFICATION_FLAGS.", "" | ||
| ), | ||
| "verification_flags": str(parsed_obj.verify_signature()).split(".")[-1], |
There was a problem hiding this comment.
Simplifies the flag by only containing the last part.
prabhu
commented
Jul 27, 2024
| @@ -561,11 +560,7 @@ def parse_pe_symbols(symbols): | |||
| if not symbol: | |||
| continue | |||
| try: | |||
| if symbol.section_number <= 0: | |||
| section_nb_str = str(lief.PE.SYMBOL_SECTION_NUMBER(symbol.section_number)).rsplit( | |||
There was a problem hiding this comment.
This was always erroring out for me so removed it.
prabhu
commented
Jul 27, 2024
| @@ -1113,6 +1106,12 @@ def add_pe_metadata(exe_file: str, metadata: dict, parsed_obj: lief.PE.Binary): | |||
| if e["name"] == "ntoskrnl.exe": | |||
| metadata["is_driver"] = True | |||
| break | |||
| rdata_section = parsed_obj.get_section(".rdata") | |||
There was a problem hiding this comment.
With this, we are able to catch more bundled .go and .dll files.
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
|
Noticed that cdxgen sbom is missing evidence with research profile. This needs to be investigated separately. cc: @aryan-rajoria |
|
@prabhu I retested against the main branch, which now has this feature branch merged. No issues to report and test cases passed as expected. |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to lief 0.15.1
https://lief.re/doc/stable/changelog.html
By parsing .rdata and .text section, we can identify more capabilities. Example below is a go binary bundled inside a PE binary. Samples here.