-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Error in binary with tag DERP but no 'name' attribute #117
Conversation
Signed-off-by: Aryan Rajoria <aryanrajoria1003@gmail.com>
Signed-off-by: Aryan Rajoria <aryanrajoria1003@gmail.com>
blint/binary.py
Outdated
elif hasattr(entry, 'runpath'): | ||
metadata["dynamic_entries"].append( | ||
{ | ||
"runpath": demangle_symbolic_name(entry.runpath), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got me thinking. Perhaps the name is "runpath" and the value is the demangled value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When debugging an entry I get name: libfdk_acc.so
, and value: 318
when tag is NEEDED
.
and, in case of RUNPATH
I get:
name: '$ORIGIN/'
value: 375
please suggest if this is okay?
@aryan-rajoria the attached files do not have those tags. Can you run the default command and share the metadata file instead? |
Metadata generated with the changes |
Signed-off-by: Aryan Rajoria <aryanrajoria1003@gmail.com>
Signed-off-by: Aryan Rajoria <aryanrajoria1003@gmail.com>
I have added RUNPATH and RPATH seperately, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes AttributeError encountered when running blint on shared libraries.
fixes #116