Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client_body_in_file_only getting deleted #187

Closed
shmurf opened this issue Mar 26, 2020 · 3 comments
Closed

client_body_in_file_only getting deleted #187

shmurf opened this issue Mar 26, 2020 · 3 comments
Assignees
@martinhsv

Comments

@shmurf
Copy link

shmurf commented Mar 26, 2020

When setting
client_body_in_file_only on;
nginx is supposed to cache the user request body to a file and NOT delete it, this is convenient for debugging.
However with modsec on I realized that the file gets deleted even when set to ON.
@martinhsv martinhsv self-assigned this Apr 2, 2020
@martinhsv
Copy link
Contributor

Hello @shmurf ,

Thank you for raising that.

I can confirm your report ... and I think I see the problem.

@martinhsv martinhsv linked a pull request Apr 8, 2020 that will close this issue
Fix client_body_in_file_only config setting not respected #192
Closed
@defanator defanator mentioned this issue Apr 8, 2020
Closed
@martinhsv martinhsv linked a pull request Apr 13, 2020 that will close this issue
Fix config setting not respected: client_body_in_file_only on #194
Closed
@github-actions
Copy link

github-actions bot commented May 3, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label May 3, 2020
@martinhsv martinhsv removed the stale label May 5, 2020
@zimmerle
Copy link
Contributor

Closed as #194 got merged! I was expecting GitHub to do it automagically :P

zimmerle pushed a commit that referenced this issue Jul 30, 2020
@martinhsv @zimmerle
Fix nginx not clearing body cache (caused by incomplete fix for #187)
11a35fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinhsv martinhsv

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zimmerle @shmurf @martinhsv