Avoid processing of subrequests initiated by the error_page #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AirisX @LeeShan87 @met3or tagging you guys here as you were testing similar bits in #90 - would be nice to get your feedback on this one as well (i.e. if it does not break things introduced in #90 then we are fine I guess) |
|
hi @defanator I'd like to give this a shot, I suppose, I should only merge this for the time being or both #90 and this? |
|
@LHorace correct. In fact, I'm still thinking about proper way to handle this - perhaps disabling modsec processing for any subrequests would be an option, but there are obvious concerns about such approach. |
|
hi @defanator
Just to clarify, just this, alright thanks. |
zimmerle
added a commit
that referenced
this pull request
Dec 9, 2019
|
Merged under dev/reload. |
|
Merged on master! thanks! |
Closed
pracj3am
pushed a commit
to cdn77/ModSecurity-nginx
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164, owasp-modsecurity/ModSecurity#2143.
Needs more investigation about possible effect on #76 as well.