Add SecArgumentsLimit to modsecurity.conf-recommended #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v3.0.5, libModSecurity has included (via #2234) a configuration directive called SecArgumentsLimit that can help protect against certain performance impacts. There is no default value, so if the configuration item is not specified, the limit is not used.
This pull request does not add any new functionality. It only supplies a default value in modsecurity.conf-recommended, along with a new rule to also reject requests that exceed the limit.
The goal here is merely to make it simpler for users (especially new users) to produce a usable and safe configuration.
Community input is welcome, particularly if:
(The current plan is to include this in v3.0.7, which is likely to be published within 2 weeks or less.)