fix: build library on OSX without GeoIP brew package #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for help, @theseion! |
theseion
requested changes
Jan 4, 2025
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
theseion
requested changes
Jan 5, 2025
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
|
theseion
approved these changes
Jan 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Build GeoIP library on OSX from source in GH workflow.
why
On OSX the GeoIP package is obsolete and could fetch through brew, therefore the GH workflow on OSX was unsuccessful, see this.