-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Create new API call to allow users to create directory configs in apr me... #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
thehelix112
wants to merge
173
commits into
owasp-modsecurity:remotes/trunk
from
thehelix112:create_config_in_user_controlled_pool
Closed
Create new API call to allow users to create directory configs in apr me... #619
thehelix112
wants to merge
173
commits into
owasp-modsecurity:remotes/trunk
from
thehelix112:create_config_in_user_controlled_pool
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vera++ and ccpcheck are not outputing to the stderr instead stdout allowing the buildbot to extract some numbers about it.
WarningCountingShellCommand allow us to have some measurements on the buildbot waterfall.
No need to use a 3rd description on the quality check scripts. Stderr is now redirected to stdout and filtered as needed.
Avoding conflicts with the standalone implementation
Makefile.in is recommended to be in the repository whenever it is edit manually, in our case the automatically generated Makefile.in is ok.
- pcre from 8.30 to 8.33 - zlib from 1.2.7 to 1.2.8 - libxml2 from 2.7.7 to 2.9.1 - curl from 7.24 to 7.33.0
Build scripts was creating links allowing the project to be loaded into Visual Studio without care about the dependencies versions. Sometimes windows refuse to delete those links leading the script to fail. This patch moves the sources directories instead of create links to it.
The unit tests was not working due to lack update. This patch adds the necessary stuff to have it work again.
Testing buildbot.
Changed to reduce the number of possible fails during Build Bot compilation.
Changes in httpd.conf.in to get it working with apache 2.4
This is needed to get it compiled with VS2011 on Windows8
The nginx config file was looking for depedencies by its own, by doing that it was ignoring the options that were passed to configure script. This commit deletes this config file and adds a meta-config which is populated by configure whenever the standalone-module is enabled.
Now using one file per line (sorted). This is the better way to handle it, since it reduces the possibility of merge conflicts.
Contains the CHANGES of the 2.7.6 release.
Release 2.7.6 ready.
… memory pools they control, rather than the default global pool every time.
Hey Filipe, Any progress with this pull-request? Is there anything that I need to address or improve? Dave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a standalone library API call that allows users to create directory_config objects in apr memory pools they control. This, coupled with #618 aims to allow users to re-configure modsecurity on the fly without effectively leaking memory.