handle invalid escape sequence passed to strmatch operator #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenosilva
added a commit
that referenced
this pull request
Nov 9, 2012
handle invalid escape sequence passed to strmatch operator
ghost
mentioned this pull request
This was referenced Oct 28, 2014
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for a coredump that happens at startup time when @strmatch operator has invalid escape sequence like following.
SecRule ARGS:value "@strmatch 89\xb6xagxga\x0a3" "phase:1,log,deny"
I'm handling the case where parse_pm_content returns NULL because of error
conditions like broken escape sequence or insufficient memory etc.
After this patch, error that looks like following is printed at startup instead of segmentation fault.
Syntax error on line 2 of /scratch/hihayash/conf/modsec.conf:
Error creating rule: Unsupported escape sequence.